Conversation
ThomasBinsfeld
approved these changes
Jul 7, 2026
acsonefho
force-pushed
the
mig-19-edi_gs1_oca
branch
3 times, most recently
from
July 23, 2026 07:41
8125395 to
3abb728
Compare
acsonefho
force-pushed
the
mig-19-edi_gs1_oca
branch
2 times, most recently
from
July 23, 2026 08:27
1649ab5 to
87e5e91
Compare
acsonefho
marked this pull request as ready for review
July 23, 2026 08:53
Contributor
Author
acsonefho
force-pushed
the
mig-19-edi_gs1_oca
branch
from
September 2, 2026 07:48
87e5e91 to
4dabf7a
Compare
acsonefho
force-pushed
the
mig-19-edi_gs1_oca
branch
from
September 10, 2026 06:34
4dabf7a to
03c5e95
Compare
simahawk
requested changes
Sep 10, 2026
acsonefho
force-pushed
the
mig-19-edi_gs1_oca
branch
2 times, most recently
from
September 10, 2026 13:36
a24f5f3 to
e53e66d
Compare
acsonefho
force-pushed
the
mig-19-edi_gs1_oca
branch
3 times, most recently
from
September 11, 2026 05:24
02fe3a4 to
75c7443
Compare
Contributor
Author
|
@simahawk Thank you very much for the review! 🙏 I hope it could be merged then improvements should be done into separated PR |
Catch XMLSchemaValueError too
…es) + add a contact details qweb template
GS1 standard requires UoM specific mapping. Here we add a specific field for it and provide mapping of values as well as auto compute for existing UoM.
* Add qweb tmpl for contact details * Fix fake res.partner record for shipper
Migrate from the legacy component-based EDI framework to the new edi_core_oca model-based architecture: - Replace components (AbstractComponent / _usage / _find_component) with model-based handlers inheriting edi.oca.handler.* abstract models. - Add edi.gs1.xml helper (XSD validate/parse), edi.gs1.input.mixin, edi.gs1.output.mixin and edi.gs1.handler.* (validate + process ack). - Wire handlers on exchange types via input/output_validate_model_id and process_model_id; move schema_path to advanced_settings (gs1: section). - Drop the edi.exchange.template.output record; render QWeb templates through the output mixin and purge nswrapper helpers (utils.py). - Update post_init_hook to the new env-based signature. - Point view inherit_id to edi_core_oca and fix module xmlids. - Adapt tests: create partners instead of removed demo xmlids and set contact details (Odoo 19 QWeb t-out uses the element body as fallback when the value is falsy).
The edi.gs1.xml model and the edi.gs1.handler.validate handler are dropped: edi.xml validates the ack types (XSD set through env_ctx) and parses the files, its _listify helper giving repeatable elements a stable shape. Drops the xmlschema dependency.
The business header declares its namespace on its own root element, so QWeb writes it out and no post-processing is needed anymore.
The `gln_code` field moves to the integration module: `res.partner._gs1_gln()` is the contract and templates render it through the `gs1_gln` helper, which also accepts the party dicts built by the shipment handlers.
A ready to use backend does not belong to an install: move it to demo, wired to its LSC/LSP parties so a delivery can resolve it. The test suite creates its own backend instead of relying on demo data.
acsonefho
force-pushed
the
mig-19-edi_gs1_oca
branch
from
September 23, 2026 08:27
a0f42be to
9522228
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on work done here: OCA/edi#411
Depends on: #343
Probably a lot of improvements to do but the purpose of this PR is only the migration.