Conversation
Contributor
Author
This was referenced Sep 10, 2026
simahawk
self-requested a review
September 15, 2026 12:15
simahawk
requested changes
Sep 15, 2026
Catch XMLSchemaValueError too
Trying to minimize issues when fwd/back porting.
This helper func was really mis-placed.
The XML handler becomes the `edi.xml` abstract model: no dependency on edi_component_oca (hence on OCA/connector) anymore, no work context, and the schema path is passed to validate() instead.
The standard Odoo helper resolves the addon relative path and forces utf-8. It also makes the "schema file not found" branch reachable: file_path used to raise outside of the try.
A repeatable element comes back as a dict for a single occurrence and as a list for several: callers iterating on it need a stable shape.
acsonefho
force-pushed
the
mig-19-edi_xml_oca
branch
from
September 23, 2026 07:55
0d1acc9 to
09f2515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of
edi_xml_ocaImprovement (into dedicated commits)
file_openfrom Odoo instead ofopen(...);_listify(...)to force having alist(when element have only a single value (but could have more; depending onxsd)xmltodictparse it like adictinstead oflistofdict.