Repository navigation
11.0.0-rc.2: six rc.1 consumer findings fixed, Channel and Dataflow wait for a full target, eight defects fixed - #85
Closed
electricessence wants to merge 69 commits into
Closed
electricessence wants to merge 69 commits into
electricessence wants to merge 69 commits into
Conversation
… source
SELECT 1; RAISERROR('late', 16, 1); completes with the row today: the read loops stop at the last row, and a provider reports an error that follows the rows only when the reader moves on.
LateErrorTests uses a reader whose NextResult (and NextResultAsync) throws, like a provider does for such an error, and asserts for every MappedQuery terminal (sync and async), the command-level Results and Retrieve, and the Channel and Dataflow pipelines that the error reaches the caller (and faults the target when complete is true); that First, Single and Take(n) read one more row to find the end of the rows and stop there when there is one; that a streaming handler that stops early is not drained; and that the reader-level helpers on a reader the caller holds leave it where it stopped. TypedReader counts NextResult calls and can be told to throw from it. Two RowMapperTests that counted the rows read now expect the one extra row.
101 of the 140 tests in LateErrorTests and RowMapperTests fail on the unfixed source.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…m 2 of the consumer feedback) ExpressiveCommand and ExpressiveDbCommand never set the Direction of the provider parameter, so Output, InputOutput and ReturnValue parameters reach the database as inputs. These tests read the direction on the provider's parameter for all four directions, sync and async, a NULL-valued output parameter, and a mixed call; they fail until the fix. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…direction (item 2 of the consumer feedback) AddParams on the generic commands never set the Direction of the provider parameter, so an Output, InputOutput or ReturnValue parameter reached the database as an input and a procedure with an output parameter failed with "expects parameter '@o', which was not supplied". The direction is now set, as the SQL Server command already did. Passes the tests added in the previous commit. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…failing: item 3 of the consumer feedback)
On the SQL Server commands the database type is SqlDbType, so AddParam("@o", DbType.Int32, ParameterDirection.Output) binds to the object overload and the enum becomes the VALUE of an output parameter. These tests, written for both packages through an extern alias, expect a typed parameter with no value; the four that need the new overload fail, and the three that pin the calls which must keep their meaning (a literal 0 above all) pass.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…parameter names through the ProcedureParameters schema collection
ExpressiveDbCommand, and ExpressiveCommand over a DbConnection, should find the real names (AddParam(orderId) as the declared order_id, a member the procedure
does not declare dropped from AddParams) through GetSchema("ProcedureParameters"): the restrictions asked for one-, two- and three-part names, the ordinal-0 return
value skipped, rows in ordinal order, an ambiguous name across schemas, a provider without the collection, a database error carrying the procedure name, and
the names remembered like the other lookups. The fake provider answers with a DataTable that has the columns of INFORMATION_SCHEMA.PARAMETERS. 24 of the 35 fail
until the lookup exists; the rest pin today's "not known" outcomes.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…L Server commands (item 3 of the consumer feedback)
ExpressiveSqlCommand in both SQL Server packages takes AddParam(string, DbType, ParameterDirection) and the AddParamIf twin, so AddParam("@o", DbType.Int32, ParameterDirection.Output) adds an Int output parameter with no value instead of an output parameter whose value is the enum. The DbType is converted to the SqlDbType the provider maps it to.
The direction has no default on purpose: an overload declared on the command hides the inherited ones wherever it applies, and a literal 0 converts to any enum, so with a default AddParam("@count", 0) would have bound to it and added a typed NULL. The tests of the previous commit pin that call, and the alias on the SQL Server package reference lets the test project reach the real commands of both packages.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…eader terminal After the natural end of the rows (a Read returned false) every terminal now calls NextResult once (NextResultAsync when it reads asynchronously), which is what makes a provider raise an error that follows the rows. This covers the Map<T>() terminals (list, array, immutable array, dictionary, hash set, first, single, and the Read and ReadAsync handlers that enumerate to the end), Results and Retrieve on commands, and the Channel and Dataflow pipelines, where the error faults the target when complete is true. First, single and Take(n) read one more row after the wanted rows: no row is the end (NextResult), a row means stop there without reading the rest. A handler that stops early is not drained. Reader-level helpers on a reader the caller holds (Results(reader), ResultsBuffered(reader), ...) leave it where it stopped, so a caller may still read the next result set. Measured with the consumer probe against SQL Server LocalDB: raw SqlClient with the default behavior and NextResult throws the error; with SingleResult|SequentialAccess, NextResult and Dispose complete without it; with SingleRow it is not raised either. The terminals therefore no longer request SingleResult (Map<T>() keeps SequentialAccess for generated mappings) or SingleRow. With that, every late-error line of the probe passes. Cost: one NextResult call per query and, for first and take, one more Read; no allocation (the allocation tests are unchanged). mapping.md states the new behavior. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…em 4 of the consumer feedback) A variable or a Func<T, object> result typed object has no members of its own, so AddParams(x) sent nothing and the procedure ran with every parameter NULL. These tests expect the members of the runtime type: an anonymous object, a Func result read at every call, different runtime types in a row, a struct, a type with no members, a null source, a throwing getter, and a ref-struct member skipped on that path. The static-type rule for every other type is pinned beside them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e type (item 4 of the consumer feedback) A Func<T, object> result or an object variable has no members of its own, so AddParams sent nothing and the procedure ran with every parameter NULL, with no error. When the static type is exactly object, the public readable properties and fields of the runtime type are used (as Dapper does); every other static type keeps its own members. A non-generic table keeps one immutable entry per runtime type, with a compiled getter per member that takes the object, so no reflection runs after the first time a type is seen; the table is weak, so an unloaded type takes its entry with it. A null source still throws ArgumentNullException. A member whose type cannot be boxed (a ref struct such as ReadOnlySpan<char>, or a pointer) made the static-type path throw TypeInitializationException for that type; the new path skips such members. The static-type path is unchanged. The AddParams remarks and the expressive-commands page say so. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…es through the ADO.NET schema collection
ExpressiveDbCommand (and ExpressiveCommand when the connection is a DbConnection) now override GetProcedureParameterNames and its async twin with a shared helper
that calls GetSchema("ProcedureParameters"): AddParam(orderId) finds @order_id and AddParams(new { ... }) drops the members the procedure does not declare on a
command made from an IDbConnectionFactory<DbConnection>, which SQL Server answers. The name is split into schema and name (brackets and quotes removed); a name with
a database part, an empty part, a provider without the collection, and a name found in more than one schema when none was given are "not known" (used as written).
A database error is thrown as it is with the procedure's name in Exception.Data["Procedure"]. The result goes through the same remembered-names path as the SQL
packages' lookup, which is unchanged. Checked on SQL Server LocalDB, also inside a transaction: it neither throws nor commits.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@name tokens The tokenizer table first (strings and '' escapes, "" and [] identifiers with their escapes, line and block comments, @@System variables, names with digits, _, $ and #, an @ with no name, an address-looking text inside a string, repeated names, names in another case), then derived names on a CommandType.Text command through ExpressiveCommand, ExpressiveDbCommand and its async path: the four tiers, ambiguity, no match, a name only in a string or comment, a collision, no token (kept as written), TableDirect and stored procedures untouched, AddParams dropping undeclared members, an explicit name winning. 85 of them fail until the tokenizer exists. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…em 5 of the consumer feedback) Map<Dictionary<string, object?>>() and Map<ExpandoObject>() return one empty row and say nothing, because the types have a public parameterless constructor and no properties to set. These tests expect the InvalidOperationException a type that cannot be mapped gets, at the call, even for an empty result, on every entry point and for every way a type is a dictionary (IDictionary, IDictionary<,>, IReadOnlyDictionary<,>) or a dynamic object (IDynamicMetaObjectProvider); an interface keeps its own reason and a model that merely holds a dictionary still maps. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…() (item 5 of the consumer feedback) Map<Dictionary<string, object?>>() and Map<ExpandoObject>() returned one empty row with no error: the types have a public parameterless constructor and no properties to set. They are not row models, so Shape.Judge now rejects any type assignable to IDictionary, to a closed IDictionary<,> or IReadOnlyDictionary<,>, or to IDynamicMetaObjectProvider, with an InvalidOperationException at the call, even for an empty result. An interface or an abstract type keeps its own reason, and a model that merely holds a dictionary still maps. The RowMap<T> remarks and the mapping page list the new case. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…its SQL text For a command of CommandType.Text the "declared names" are now the @name tokens in the command text, matched with the same four tiers as the parameters of a stored procedure (on ExpressiveCommand, ExpressiveDbCommand and ExpressiveSqlCommand, sync and async), so AddParam(regionId) on "... WHERE region_id = @region_id" sends @region_id and AddParams(new { ... }) sends only the members the text uses. The internal tokenizer (SqlTextParameters) returns the distinct tokens in order of first appearance (the same name in another case once) and skips single-quoted strings, double-quoted and [bracketed] identifiers, -- and /* */ comments and @@System variables; only @ is recognised. The result is remembered per command text (at most 256 texts, then the cache starts again). A text with no @name token keeps the argument's name as written, so nothing that works today changes; ambiguity and no match throw the same InvalidOperationException as for a procedure. Three existing tests that pinned "a text command with @ in it uses the name as written" now use a text without a marker (or expect the marker). Docs: the expressive-commands article, the AddParam/AddParams XML remarks and the MSSqlClient README line. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nge instead of Substring, CA2249 Contains where the target has it) The full gate listed both at --severity info after the two items; no behavior change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Shared three-column fixtures with a tracked reader that counts reads and can run code (a cancel) as a read starts, a command that hands out a plain IDataReader (not a DbDataReader), and the behavior each execution of FakeExecuteReader was asked for. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…olumn, cancellation before and during, what is left of a connection Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rly stop, pooled rows, deferred execution, NULLs Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…, zero and negative counts, async with the command's token and connection Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…re not mapped, a plain IDataReader agrees, the token reaches the query Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…of values read by ordinal Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…and carry no closures, delegates or adapter, and AddParams sizes its list Attributed with the runtime's allocation ticks (ODE against Dapper on SQL Server LocalDB), then removed what is safe and clearly cheap: - ExecuteTransaction, ExecuteTransaction<T> and ExecuteTransactionConditional(Func<bool>) (Core and SqlClient) passed the caller's function through two closures and two delegates per call (88 to 176 B); they now pass it through the state of a private core with static lambdas. - A command made from a typed connection factory held the factory through a delegate to its Create method plus a boxed adapter struct (88 B per command); it now holds one small pool object (24 B) that calls Create and disposes the connection as before. - AddParams makes its list at the size of the members instead of the default four slots of a 48 B struct. Allocation tests on an in-memory provider that allocates nothing pin each saving against the hand-written equivalent; nothing public changes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… the new code (naming, an unused using, a local function, const locals, class bodies, one dismissal with its reason) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…unmappable list and the limits Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…he provider fails to execute Every reader extension on IDbCommand and DbCommand that opens a closed connection (ToList, ToArray, ToDataTable, ExecuteReader, IterateReader, First, Take, FirstOrdinalResults, Retrieve and their async forms) is run against a tracking fake whose command throws on execute, or throws a cancellation, and the connection must have been opened once and closed once; a connection the caller opened must be left alone. These tests fail until the fix. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…er fails to execute A reader extension that opens a closed connection added CommandBehavior.CloseConnection and then executed outside any try, but without a reader nothing closes the connection. The open and execute steps are now one helper (sync, DbCommand sync, async) that closes what it opened when the execute throws or is cancelled and leaves a connection the caller opened alone; a failure to close never replaces the exception being reported. The success path is unchanged. Applied to every call site in CommandExtensions and to the same copies in the SqlClient and MSSqlClient packages. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…LocalDB is missing The tests that need a real server (the SQL Server package's typed SqlCommand and SqlTransaction extensions) call LocalDbFixture.SkipUnlessAvailable first. It checks once per run that (localdb)\MSSQLLocalDB answers, reports the test as skipped when it does not, and hands out connections to tempdb and uniquely named scratch tables and procedures that are dropped afterwards. ODE_TEST_NO_LOCALDB forces the skip. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…hen the provider fails to execute Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…s move the reader on, the older terminals that still ask for SingleResult, the upgrade count, a constant 0 on the SQL commands, DECLARE variables, the lookup remark, one name-check order) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… and the public API baseline (#86) Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
…cate, never advance a reader that is not theirs These fail on the current code (125 of 233 in the three classes): - a bounded Dataflow target behind a slow consumer receives every row from the synchronous ToTargetBlock overloads (reader level and command level); - a command level ToChannel call runs at once against a full bounded channel, delivers every row as it drains and closes the connection; a cancel on a target that never drains ends it with the cancellation, the connection closed and (complete: true) the target completed; - a reader level overload (Channel and Dataflow, sync, async, AsSourceBlock) leaves the next result set to the caller. Also pinned (they pass today): a closed target ends a Channel call with ChannelClosedException; a command level call raises an error that follows the rows; a Dataflow command level call whose target declined stops without moving the reader. The wait-cancelled test file is rewritten as the full-target test file. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…dvance a reader that is not theirs - A full target only means wait: the synchronous ToTargetBlock overloads and the mapped sync pipeline send with SendAsync instead of Post, which refused a bounded target that was merely full and cut the result short. The mapped sync path watches the target the way the async path does. - No wait for room before the command runs: WaitForRoom and its nine call sites are deleted. A call opens, executes, reads, and each write waits for room; with complete: true the target is completed however the call ends. - A reader that belongs to the caller is not advanced: the reader level overloads stop calling NextResult (ThenNextResult and EndOfRows are deleted); the Channel command level code, which owns its reader, calls it once after the rows ran out. The Dataflow command level overloads no longer raise an error that follows the rows (they cannot tell that without reading ahead); documented. - XML docs and the Channel and Dataflow article say how to stop a running call (cancel it, then complete the target) and that the sync Dataflow overloads have no token. Tests that pinned the removed behaviors are rewritten or deleted. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
The SqlClient and MSSqlClient ExecuteReader helpers each carried a byte-identical copy of CloseOpened and CloseOpenedAsync. They call the Core helpers (internal, already visible to both packages); the behavior on every target framework is the same. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Text commands with derived names parse their SQL once per command; the bounded cache of 256 texts had no measured need. The two tests of the cache go with it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e sync DbCommand OpenAndExecuteReader overload goes Its only caller read through the IDataReader overload of FirstOrdinalResults, which forwards to the same DbDataReader code. The async DbCommand overloads stay. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…tion theories go FirstBehavior was an alias of Behavior; the reason for not asking for SingleRow moves to GeneratedMapping. The two sync SendsTheDirectionOfTheParameter theories repeat what the async theory and the every-kind procedure-call test already assert on both command types. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
… message as an unsupported provider NotSupportedException, NotImplementedException and ArgumentException still mean the provider does not support the ProcedureParameters collection; any other failure propagates with Data["Procedure"] as before. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…-struct and pointer members A ReadOnlySpan<char> or pointer member is not supported on AddParams; the typed and the object paths now find members the same way. The test of the skip and the sentences that described it go. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
A text command resolved its derived names without the cache but still built a key of data source, database and the whole SQL text for it. The key is built in the stored-procedure branch; the retry, which only a procedure can reach, builds it again. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
UnmappableTypeTests drops the dictionary and ExpandoObject entry-point matrices and three rows; LateErrorTests keeps one clean case each (NextResult once) and drops duplicate terminals and the Skip-then-First peek; CommandExecuteFailureTests keeps the ProviderFails theories in full, feeds the other variants one name per overload shape, drops the cancelled-while-executing twin and fixes a wrong comment and a misleading name; MappedQueryEdgeTests drops two LINQ-through-a-stub tests; ExecuteReaderEdgeTests drops the IterateReaderWhile twin; unreachable switch arms and flags go from the Retrieve, DataReader, ExecuteReader and MappedQuery tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…e path - ToChannelFullTargetTests: IDbCommand, DbCommand mapped and IExecuteReader mapped (complete true and false); DrainUntilCompleted and its timed wait are replaced by a plain drain and a check of the completion. - ToTargetBlockFullTargetTests: six sync shapes. ReaderOwnershipTests: the twelve plain and mapped shapes. - The late error of the tracked reader is set once where the reader is built; one-line comment in Dataflow Transformer; one short sentence per Channel overload in place of the repeated paragraph. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…g, Fixes and the mapping page already say Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ommand overloads say they report no late error whats-new-11.md: the pipelines wait for room (the synchronous ToTargetBlock overloads too), a reader you pass in is never moved on, only the Channel overloads that run a command raise an error that follows the rows, and a new Known limitations bullet says the Dataflow overloads that run a command do not. The 20 command-level AsSourceBlock and AsSourceBlockAsync overloads say it in their remarks. Two small wording fixes (README, expressive-commands). No code change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ion, complete after the call starts, sync AsSourceBlock hang, token on netstandard, MappedQuery terminals, InvalidOperationException on async Dataflow commands) The mapped ToChannel overloads throw ChannelClosedException on a completed target only when the result is larger than the internal buffer; a small result can return its count with nothing delivered. The "completed however the call ends" claim holds once the call has started, not for an argument check that throws first. The synchronous AsSourceBlock never returns with a bounded capacity smaller than the result. On netstandard2.0 and 2.1 the token is checked only before the parameter-name lookup starts. The terminals listed as unchanged are the older reader.Select extensions, not MappedQuery<T>. The async ToTargetBlockAsync overloads on a command now document InvalidOperationException (no connection). Words only, no code change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…nization context in the Core command helpers and the expressive commands EnsureOpenAsync was called with its default (configureAwait: true) by the Core OpenAndExecuteReaderAsync, by ExpressiveCommandBase and by the connection-factory helpers, so a call that opened a closed connection resumed on the caller's context after the open; a caller that blocked on it from such a thread could deadlock. The SQL Server command helpers and the transaction helpers already passed false. The call sites now pass false. A new case in ConfigureAwaitTests covers a Core command helper and an expressive command (it failed before the change with 2 posts back to the context). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
electricessence
changed the base branch from
fix/consumer-feedback-rc1-fixes
to
master
November 9, 2026 06:58
…ngleResult and SingleRow sent as on master, docs say how to read several result sets A next result set is not always the same shape, so moving to it is the consumer's decision. Core, Channel and Dataflow no longer call NextResult or NextResultAsync on any path, including a reader the library opened. An error a provider raises after the last row (a SELECT then a RAISERROR) is therefore not seen unless the caller calls NextResult. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…provider and Never-NextResult tests (#87) A new page shows how to read several result sets with the caller's NextResult, including the SQL Server error that follows the rows. mapping.md compares Map<T>() and Results<T>(); foundation.md no longer says Results<T>() queues rows. XML docs say the reader-level mappers read the current set only. No library behavior or public API changes. Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is everything for 11.0.0-rc.2 in one pull request: fixes for what a production app found in rc.1, pipelines that wait for room in a full target, eight defects fixed, fewer allocations, and the version bump.
AddParams(x)withxtypedobjectsends the members of its real type.Map<Dictionary<..>>()andMap<ExpandoObject>()throw, where they used to return one empty row.AddParam(name, DbType, direction)works on the SQL Server commands. Parameter names are found through anyDbConnectionand from the@namemarkers in SQL text. The first finding, a SQL error raised after the last row (for exampleRAISERRORafter aSELECT) that is not reported, is not fixed, by design. The library reads one result set and never moves to the next one, because only the caller knows how many sets there are and what shape they have. A caller who needs that error takes the reader and callsNextResultthemselves; the "Several result sets" section ofdocsite/articles/mapping.mdshows how. The other three findings ask for new API and are not in this change.NextResultNextResult. A call on a command reads one result set.SingleResultandSingleRoware sent as in rc.1.Retrieve, the reader extensions,ToChannelwith a transform).ToDataTablesskipped or threw on result sets; it now returns oneDataTableper result set.ToChannelwithcomplete: truenow completes the target however the call ends once it has started. Five calls get a null check.ToChannel,ToTargetBlockandAsSourceBlockwrite rows to a bounded target (one with a size limit). They now wait for room in a full target. Before, the sync calls stopped and cut the result short. A call on a command runs the command at once instead of waiting for room first. A reader you pass in is yours: these calls leave it where the rows ended.AddParams48 to 144 B less, the sync transaction helpers 176 B less. Allocation tests check these.11.0.0-rc.2in the build, the README and the release notes. The three new public overrides move to the shipped API list.Verification
dotnet format(style and analyzers, all severities): 0 findings in nine projects. Roslynator (an extra code analyzer): 0 findings in ten projects. A scan of each target framework in Debug still lists info-level items:!operators flagged only because of a Debug-only null check (Release needs them), and one pattern-matching suggestion in a sample.11.0.0-rc.2. A consumer program passes on .NET Framework 4.8 (21 checks), .NET 8 (20), .NET 9 (20) and .NET 10 (21), 0 failed, and builds with a C# 12 compiler.ToDataTableson two sets.Limits you should know
NextResultto see it.AsSourceBlockwith a bounded capacity smaller than the result never returns, because nobody can read the block until the call returns. UseAsSourceBlockAsync.ToChannel(one that maps rows to a type) into a target that is already completed throws only for a result above the internal buffer of 1,024 rows. A smaller result is read and the count is returned.AddParamsis not supported for a source with aReadOnlySpan<char>member (a ref struct, a type that cannot be boxed): it fails.🤖 Generated with Claude Code