Repository navigation
fix(records): a held PDF's card puts its words under the page at large text on a phone - #926
Merged
Merged
Conversation
…e text on a phone Found by the daily QA of 21 November, checking #924. At 200% text on a phone the lock card left its words a column of 30 to 100px, and "community's" ran out of the card. Under 12rem the words go under the page; the card for a PDF on another site shares the layout and does the same.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by the daily QA of 21 November, checking #924 on Admin QA 8 October 2026.
Problem
A record whose PDF is kept from readers shows a lock card on its public page. At 200% text on a phone the page picture kept its 4rem beside the words, which were left a column of 30px (320px phone) to 100px (390px). The explanation's longest word, "community's", needs 161px, so it ran out of the card, and the title broke inside words ("PDF priva te"). Chromium, Firefox and WebKit. The card for a PDF on another site has the same layout.
Change
Both cards share one
SideCard. Under 12rem of card width (a phone at 150% text or more; at normal text a phone's card is 16rem or wider) the words go under the page, as the card for a stored PDF already does on phones. The longest word of these lines in any language (Zulu "abangayivula.") needs about 6.5rem, which the side layout still gives above 12rem. Fromsmup the cards stay side by side at any text size, so only phones change.Checks
On the verify stack, with one seeded record set to private and one embargoed to 1 June 2027, this branch against main:
npm run verify -- shift /lib/V2222226(1440x900) and/lib/V2222223(390x844): pass in Chromium and Firefox; the shifts listed are on main too.npx tsc --noEmit, eslint on the file,npm run check:ui-rules,npm run quality:fallow -- --base origin/main.@container side (min-width: 12rem)for both classes.sm:flex-row.SideCard.