Skip to content

fix(records): a held PDF's card puts its words under the page at large text on a phone - #926

Merged
sickerine merged 2 commits into
mainfrom
fix/held-pdf-large-text
Nov 21, 2026
Merged

sickerine merged 2 commits into
mainfrom
fix/held-pdf-large-text

Conversation

@sickerine

@sickerine sickerine commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Found by the daily QA of 21 November, checking #924 on Admin QA 8 October 2026.

Problem

A record whose PDF is kept from readers shows a lock card on its public page. At 200% text on a phone the page picture kept its 4rem beside the words, which were left a column of 30px (320px phone) to 100px (390px). The explanation's longest word, "community's", needs 161px, so it ran out of the card, and the title broke inside words ("PDF priva te"). Chromium, Firefox and WebKit. The card for a PDF on another site has the same layout.

Change

Both cards share one SideCard. Under 12rem of card width (a phone at 150% text or more; at normal text a phone's card is 16rem or wider) the words go under the page, as the card for a stored PDF already does on phones. The longest word of these lines in any language (Zulu "abangayivula.") needs about 6.5rem, which the side layout still gives above 12rem. From sm up the cards stay side by side at any text size, so only phones change.

Checks

On the verify stack, with one seeded record set to private and one embargoed to 1 June 2027, this branch against main:

main this branch
320 at 200% words 30px wide, explanation needs 161px words under the page, 190px, nothing cut
390 at 200% (Chromium, WebKit) 100px, cut under the page, 260px, nothing cut
390 at 150% beside, 172px the same
390 at 100% beside, 244px the same
1440 at 100% and 200% beside the same
  • npm run verify -- shift /lib/V2222226 (1440x900) and /lib/V2222223 (390x844): pass in Chromium and Firefox; the shifts listed are on main too.
  • npx tsc --noEmit, eslint on the file, npm run check:ui-rules, npm run quality:fallow -- --base origin/main.
  • The compiled CSS has @container side (min-width: 12rem) for both classes.
  • Reviewed by GPT-6.1 Sol: one finding (the stacked default also applied above phone width, e.g. 640px at 250% text), fixed with sm:flex-row.
  • The verify stack has no record with a PDF on another site; that card uses the same SideCard.

…e text on a phone

Found by the daily QA of 21 November, checking #924. At 200% text on a phone the
lock card left its words a column of 30 to 100px, and "community's" ran out of
the card. Under 12rem the words go under the page; the card for a PDF on another
site shares the layout and does the same.
@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ab50a8a1-4ffa-40d9-aff2-b924f86ae4b6
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T08:08:34.810564Z 34992cf New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sickerine
sickerine merged commit 0b2ac38 into main Nov 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant