Skip to content

fix(records): a record whose rights name another licence says so and offers it - #928

Merged
sickerine merged 2 commits into
mainfrom
fix/licence-contradicts-rights
Nov 21, 2026
Merged

sickerine merged 2 commits into
mainfrom
fix/licence-contradicts-rights

Conversation

@sickerine

Copy link
Copy Markdown
Collaborator

The user's choice from the daily QA of 21 November (decision 3).

Problem

A hand-made record starts with the community's default licence, CC BY 4.0. Changing its rights to "All rights reserved." left that licence in place, the note under the field still said "The community's default licence", and nothing offered the licence the rights name (Other (Not Open), since #923).

Change

When a record's rights name a licence other than the one it has, the note says "Its rights name Other (Not Open), not CC BY 4.0." and the field's button offers "Use Other (Not Open)". A licence of the record's own (name and link) counts as other when the rights name one of Zenodo's, or keep every right while it is open. A closed licence of its own under "All rights reserved" agrees with its rights and gets no note.

Checks

  • tests/unit/licence-input.test.tsx: with CC BY 4.0 and "All rights reserved" rights, the button gives Other (Not Open); rights that name CC BY 4.0, or no licence, offer nothing; an open licence of the record's own under "All rights reserved" gets the offer, a closed one doesn't.
  • tests/unit/licences.test.ts, npx tsc --noEmit, eslint, npm run quality:fallow -- --base origin/main.
  • After the release: Admin QA's record editor on dev.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4f41ad1d-e230-478c-b61b-ab66d681385e
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-21T14:54:03.787337Z c72bf6b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sickerine
sickerine merged commit eb51d2b into main Nov 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant