Repository navigation
fix(records): a record whose rights name another licence says so and offers it - #928
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user's choice from the daily QA of 21 November (decision 3).
Problem
A hand-made record starts with the community's default licence, CC BY 4.0. Changing its rights to "All rights reserved." left that licence in place, the note under the field still said "The community's default licence", and nothing offered the licence the rights name (Other (Not Open), since #923).
Change
When a record's rights name a licence other than the one it has, the note says "Its rights name Other (Not Open), not CC BY 4.0." and the field's button offers "Use Other (Not Open)". A licence of the record's own (name and link) counts as other when the rights name one of Zenodo's, or keep every right while it is open. A closed licence of its own under "All rights reserved" agrees with its rights and gets no note.
Checks
tests/unit/licence-input.test.tsx: with CC BY 4.0 and "All rights reserved" rights, the button gives Other (Not Open); rights that name CC BY 4.0, or no licence, offer nothing; an open licence of the record's own under "All rights reserved" gets the offer, a closed one doesn't.tests/unit/licences.test.ts,npx tsc --noEmit, eslint,npm run quality:fallow -- --base origin/main.