Add a FixType filter to the Fix common errors rule list - #14443
Closed
ivandrofly wants to merge 2 commits into
Closed
ivandrofly wants to merge 2 commits into
ivandrofly wants to merge 2 commits into
Conversation
Every fix rule now declares the kind of fix it performs via a new FixType enum (Time, Formatting, Dialog, Punctuation, Casing, Spacing, Characters, Ocr), so the UI/CLI can group, filter or sort rules by category later. The member is abstract on the interface so the compiler enforces it on all 40 implementations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TTVPifejhQqpeh1mkQHeRg
Step 1 lists every rule flat, and the search box meant to narrow it was created but never added to the window. Add a "Type" combo that filters the grid by the rule's FixType, ANDed with the search text, and place both in the step 1 toolbar. The filter follows a profile switch, and hidden rules keep their selection because apply/save read the profile's full list. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SXEWrgv5uAnSzDgxFupSHZ
3 tasks
Member
|
Hi @ivandrofly, closing this along with #14442 - see my note there. I'd rather keep the Fix common errors rule list simple for now, so I'm not going to add a type filter at this point. The observation that the "Search rules..." box was never added to the window is a good catch though, so I'll look at that separately. Thanks for the work on it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #14442 (the
FixTypeproperty onIFixCommonError); this PR's own change is the top commit.Summary
FixType(All, Time, Formatting, Dialog, Punctuation, Casing, Spacing, Characters, OCR).FixRuleDisplayItemresolves itsFixTypeonce from the fix classes (one lazily built name-to-type map), so libse stays the single source of truth; the copy constructor carries it into profile clones.FixTypeFormatting,FixTypeDialog,FixTypePunctuation,FixTypeOcr(the other four reuse existing General strings);English.jsonregenerated.FixCommonErrorsRuleFilterTests(type filter, AND with search, profile switch, hidden selection kept, type resolution for every default and language-specific rule, window wiring and step visibility).Test plan
dotnet test tests/UI/UITests.csproj:FixCommonErrorsRuleFilterTestspass🤖 Generated with Claude Code
https://claude.ai/code/session_01SXEWrgv5uAnSzDgxFupSHZ