refactor(network): Remove obsolete HTTP Proxy option

[githubawn]

What this code did:

The TextEntryHTTPProxy option in OptionsMenu.cpp:

1. Saved/read an HTTP proxy server address from the Windows Registry (Proxy) in HKLM\SOFTWARE\Electronic Arts\EA Games\Command and Conquer Generals Zero Hour.
2. Configured GameSpy's ghttpSetProxy() for HTTP web requests (MOTD news bulletins and patch checks).

Background & Reason for Removal:

• Scope Limitation: HTTP Proxy only affects HTTP TCP requests (web bulletins). It does not proxy peer-to-peer UDP game traffic or match sockets.
• Player Confusion: Players frequently misinterpret "Proxy" in the game options as a full network proxy to route multiplayer matches or bypass UDP firewall rules.
• GUI Cleanliness: Calling textEntryHTTPProxy->winHide(TRUE) in C++ hides the obsolete setting from the Options menu without breaking custom/legacy .wnd layout assets.
• UAC & Registry Safety: Eliminates 1 of the 4 runtime write to HKEY_LOCAL_MACHINE (HKLM) that caused Windows UAC permission failures (ERROR_ACCESS_DENIED) when playing without Administrator privileges on certain variants of Windows.

[greptile-apps]

Greptile Summary

This PR removes the obsolete HTTP proxy option across the game and patch-checking paths.

• Stops reading and applying the Proxy registry value during GameSpy and PATCHGET HTTP requests.
• Stops saving proxy configuration from both Generals and Zero Hour option menus.
• Hides the legacy proxy text field and label while retaining compatibility with existing .wnd layouts.

Confidence Score: 5/5

The PR appears safe to merge with no blocking failures identified.

No blocking failure remains.

Important Files Changed

Filename	Overview
Core/GameEngine/Source/GameNetwork/GameSpy/MainMenuUtils.cpp	Removes the registry-backed HTTP proxy configuration from the in-game patch and bulletin request path.
Core/Tools/PATCHGET/CHATAPI.cpp	Removes the same proxy configuration from the standalone PATCHGET request path.
Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp	Removes proxy persistence and hides the obsolete controls in the Generals options menu.
GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp	Mirrors the options-menu cleanup for Zero Hour.

_{Reviews (2): Last reviewed commit: "refactor(network): Remove obsolete HTTP ..." | Re-trigger Greptile}

[xezon]

Instead of removing the http proxy port, would it be possible to repurpose is and bind net packet traffic for game messages hrough it or is that not needed or possible?

[githubawn]

Not needed IMHO.
The common desktop OSs already have this built in if a user wants it with decades of stability work.
We shouldn't add features that could increase latency for everyone else.

[xezon]

Better put a tweak comment here that this stuff was removed and obsoleted by us for reasons.

[tintinhamans]

Have you validated that the game actually respects the OS proxy settings? Also we should consider http_proxy and https_proxy environment variable support along with command line flags to support e.g. Linux and macOS.

[githubawn]

The original code relied on its own internal registry keys rather than OS settings; it does not follow the OS proxy settings. Will update the description.

Adding http_proxy / https_proxy support would just reintroduce player confusion (thinking it routes P2P game traffic) and unnecessary code complexity.

If someone actually needs to proxy HTTP (or UDP) traffic for this game, better system-level tools and wrappers already exist to handle that far more cleanly.

I'll be happy to add the switch if users report that they need this switch without having superior options already available.

[xezon]

I think this code here can go behind the ENABLE_GUI_HACKS define because the best fix for hide is to remove these elements from the WND data files.