refactor(core): remove temporary locationServiceMapLayer constant#36204
Open
Robin1987China wants to merge 1 commit into
Open
refactor(core): remove temporary locationServiceMapLayer constant#36204Robin1987China wants to merge 1 commit into
Robin1987China wants to merge 1 commit into
Conversation
All call sites migrated to buildLocationServiceMap() factory. The constant was marked 'temporary for backwards compatibility' and its usage in server.ts was already migrated upstream.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
N/A — refactor PR (refactor PRs skip issue requirement per contributing guidelines)
Type of change
What does this PR do?
Removes the temporary
locationServiceMapLayerconstant fromlocation-services.ts. All call sites migrate to thebuildLocationServiceMap()factory. The constant was marked "temporary for backwards compatibility" and its usage was already partially migrated upstream.How did you verify your code works?
bun typecheckinpackages/coreandpackages/opencode(0 errors). All 8 remaining call sites migrated;git grep locationServiceMapLayerreturns nothing.Checklist