Skip to content

feat(transport): rust zenoh client and router support - #3464

Merged
aclauer merged 18 commits into
mainfrom
andrew/feat/zenoh-router-client-support
Aug 19, 2026
Merged

feat(transport): rust zenoh client and router support#3464
aclauer merged 18 commits into
mainfrom
andrew/feat/zenoh-router-client-support

Conversation

@aclauer

@aclauer aclauer commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Contribution path

  • Small, safe change that does not need a tracking issue
  • Linked issue or discussion: DIM-XXX / #XXX / URL

Problem

I didn't add zenoh router and client modes because I was lazy and just used peer mode for everything.

Solution

Now we can pass more configs to the Rust zenoh transport:

  • mode, connect, listen, mutlicast, interface, gossip

How to Test

from examples/native-modules

python rust_ping_pong.py --transport zenoh <- runs with both modules on peer mode
python rust_ping_pong.py --transport zenoh --topology <- runs with pong as router and ping as client, shows in logs

AI assistance

Checklist

  • I have read and approved the CLA.

@codecov

codecov Bot commented Aug 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.47552% with 3 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
dimos/core/native_module.py 93.33% 1 Missing and 1 partial ⚠️
dimos/protocol/service/test_zenohservice.py 97.77% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
+ Coverage   76.13%   76.24%   +0.11%     
==========================================
  Files        1228     1235       +7     
  Lines      119172   119672     +500     
  Branches    10684    10688       +4     
==========================================
+ Hits        90729    91244     +515     
+ Misses      25344    25328      -16     
- Partials     3099     3100       +1     
Flag Coverage Δ
OS-ubuntu-24.04-arm 70.69% <99.47%> (+0.15%) ⬆️
OS-ubuntu-latest 72.46% <99.47%> (+0.13%) ⬆️
Py-3.10 72.46% <99.47%> (+0.14%) ⬆️
Py-3.11 72.46% <99.47%> (+0.14%) ⬆️
Py-3.12 72.46% <99.47%> (+0.13%) ⬆️
Py-3.13 72.46% <99.47%> (+0.14%) ⬆️
Py-3.14 72.46% <99.47%> (+0.13%) ⬆️
Py-3.14t 72.46% <99.47%> (+0.14%) ⬆️
SelfHosted-Large 29.79% <40.55%> (+0.04%) ⬆️
SelfHosted-Linux 35.81% <43.70%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/conftest.py 82.03% <100.00%> (+0.66%) ⬆️
dimos/core/coordination/module_coordinator.py 86.24% <100.00%> (+0.13%) ⬆️
dimos/core/coordination/python_worker.py 72.87% <100.00%> (ø)
dimos/core/coordination/test_module_coordinator.py 98.36% <100.00%> (+0.02%) ⬆️
dimos/core/coordination/test_worker.py 99.15% <100.00%> (+0.04%) ⬆️
dimos/core/global_config.py 86.13% <100.00%> (+1.03%) ⬆️
dimos/core/test_native_module.py 97.66% <100.00%> (+0.41%) ⬆️
dimos/core/test_transport_factory.py 100.00% <100.00%> (ø)
dimos/core/transport_factory.py 100.00% <100.00%> (ø)
dimos/protocol/service/conftest.py 100.00% <100.00%> (ø)
... and 13 more

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aclauer aclauer changed the title Andrew/feat/zenoh router client support feat(core): rust zenoh client and router support Aug 14, 2026
@aclauer
aclauer marked this pull request as ready for review August 14, 2026 18:45
@aclauer aclauer changed the title feat(core): rust zenoh client and router support feat(transport): rust zenoh client and router support Aug 14, 2026
@aclauer
aclauer marked this pull request as draft August 15, 2026 01:09
@aclauer
aclauer marked this pull request as ready for review August 16, 2026 17:04
@github-actions github-actions Bot added ready-to-merge Required CI checks have passed on this PR and removed ready-to-merge Required CI checks have passed on this PR labels Aug 17, 2026
@aclauer
aclauer force-pushed the andrew/feat/zenoh-router-client-support branch from 95e7da5 to 92ae414 Compare August 18, 2026 20:41
@github-actions github-actions Bot removed the ready-to-merge Required CI checks have passed on this PR label Aug 18, 2026
@greptile-apps

greptile-apps Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The change adds configurable Zenoh peer, client, and router sessions across Python services and Rust native modules. It forwards resolved session settings through the native-module launch configuration and adds coverage for topology, discovery, connection timeout, and session wire formats.

Confidence Score: 5/5

No blocking failure remains.

No accepted P0 or P1 findings remain.

Reviews (3): Last reviewed commit: "Clean up and fixes" | Re-trigger Greptile

@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Aug 18, 2026
@aclauer
aclauer force-pushed the andrew/feat/zenoh-router-client-support branch from 92ae414 to 88c62e3 Compare August 19, 2026 17:52
@github-actions github-actions Bot removed the ready-to-merge Required CI checks have passed on this PR label Aug 19, 2026
@aclauer
aclauer force-pushed the andrew/feat/zenoh-router-client-support branch from 88c62e3 to f21f438 Compare August 19, 2026 22:01
@aclauer
aclauer enabled auto-merge August 19, 2026 22:15
@aclauer
aclauer added this pull request to the merge queue Aug 19, 2026
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Aug 19, 2026
Merged via the queue into main with commit 4bfcb23 Aug 19, 2026
35 checks passed
@aclauer
aclauer deleted the andrew/feat/zenoh-router-client-support branch August 19, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants