Skip to content

Benchmark replay - #3524

Open
Dreamsorcerer wants to merge 15 commits into
mainfrom
sam/replay-cpu-benchmark
Open

Benchmark replay#3524
Dreamsorcerer wants to merge 15 commits into
mainfrom
sam/replay-cpu-benchmark

Conversation

@Dreamsorcerer

Copy link
Copy Markdown
Collaborator

No description provided.

@mintlify

mintlify Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
dimensional 🟢 Ready View Preview Aug 18, 2026, 3:01 PM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.82759% with 51 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
dimos/robot/unitree/go2/test_replay_benchmark.py 64.82% 43 Missing and 8 partials ⚠️
@@            Coverage Diff             @@
##             main    #3524      +/-   ##
==========================================
+ Coverage   76.06%   77.25%   +1.19%     
==========================================
  Files        1226     1263      +37     
  Lines      118922   121848    +2926     
  Branches    10666    11098     +432     
==========================================
+ Hits        90463    94139    +3676     
+ Misses      25381    24522     -859     
- Partials     3078     3187     +109     
Flag Coverage Δ
OS-ubuntu-24.04-arm 71.03% <20.00%> (+0.57%) ⬆️
OS-ubuntu-latest 72.76% <20.00%> (+0.51%) ⬆️
Py-3.10 72.76% <20.00%> (+0.51%) ⬆️
Py-3.11 72.76% <20.00%> (+0.51%) ⬆️
Py-3.12 72.76% <20.00%> (+0.52%) ⬆️
Py-3.13 72.76% <20.00%> (+0.51%) ⬆️
Py-3.14 72.76% <20.00%> (+0.51%) ⬆️
Py-3.14t 72.76% <20.00%> (+0.51%) ⬆️
SelfHosted-Large 31.79% <64.82%> (+2.02%) ⬆️
SelfHosted-Linux 36.01% <20.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dimos/robot/unitree/go2/test_replay_benchmark.py 64.82% <64.82%> (ø)

... and 136 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Dreamsorcerer Dreamsorcerer changed the title Test benchmark Benchmark replay Aug 19, 2026
@Dreamsorcerer
Dreamsorcerer marked this pull request as ready for review August 20, 2026 16:34
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Aug 20, 2026
@greptile-apps

greptile-apps Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This change adds Go2 replay-performance benchmarking with a read-only execution job and a separate reporting job for trusted publishing and pull-request feedback. Executed checks confirmed that benchmark code runs without repository write permission, the reporting job does not execute checked-out pull-request code, and benchmark metric fields are handled as data rather than executable input.

Confidence Score: 5/5

No blocking failure remains; the privilege boundary and metric-handling paths were exercised successfully.

No accepted blocking findings remain.

T-Rex T-Rex Logs

What T-Rex did

  • The token boundary validation script was executed from the repository root against a vulnerable test case, exited with code 1, and triggered a write-token fixture to identify checkout-derived execution.
  • The same script was run against the CI workflow YAML to verify the current privilege boundary, and that run exited with code 0.
  • Before-and-after log artifacts for the benchmark validation script were collected so the test results could be reviewed.
  • Benign and malicious benchmark parser tests were performed, with the malicious run completing without creating a marker file to prove payload text was not executed.
  • Review confirms that no repository source files were modified during the tests; only the required test sources and command-captured proof logs were added under the artifact collection.

View all artifacts

T-Rex Ran code and verified through T-Rex

Reviews (2): Last reviewed commit: "Cleanup" | Re-trigger Greptile

Comment thread .github/workflows/ci.yml Outdated
@github-actions github-actions Bot removed the ready-to-merge Required CI checks have passed on this PR label Aug 20, 2026
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant