fix(memory): make recorder lossless under load - #3558
Open
TomCC7 wants to merge 58 commits into
Open
Conversation
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #3558 +/- ##
==========================================
+ Coverage 77.10% 77.15% +0.04%
==========================================
Files 1262 1264 +2
Lines 120300 120626 +326
Branches 10634 11238 +604
==========================================
+ Hits 92758 93067 +309
- Misses 24461 24462 +1
- Partials 3081 3097 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This reverts commit 3950b0e.
paul-nechifor
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Recorder data loss under sustained sensor load and temporary encoder or SQLite stalls. Every message accepted by Recorder is persisted in callback-arrival order, or recording fails visibly.
Approach
pSHMTransport; its default remains the existing latest-value transport.Stream.append()path.Verification
The standalone recorder benchmark compares the generated source manifest with the completed memory2 database. Its 30-second production profile contains 22,500 observations: RGB 30 Hz, two grayscale streams at 30 Hz, depth 30 Hz, IMU 400 Hz, PointLIO 10 Hz, odometry 200 Hz, and TF 20 Hz.
All three experiments stored 22,500/22,500 observations with no missing, duplicate, corrupt, or reordered payloads:
Each run sustained 64.85 MiB/s offered raw data, 38.88 MiB/s encoded payload, and about 39.07 MiB/s SQLite growth.