Skip to content

chore(ci): remove Dependabot, add Claude + Copilot code review - #32

Open
srpatcha wants to merge 1 commit into
masterfrom
chore/audit-and-ci
Open

chore(ci): remove Dependabot, add Claude + Copilot code review#32
srpatcha wants to merge 1 commit into
masterfrom
chore/audit-and-ci

Conversation

@srpatcha

Copy link
Copy Markdown
Member

Dependabot removed

Dependabot is disabled across the organisation:

  • .github/dependabot.yml deleted here
  • Dependabot alerts and automated security fixes turned off via the API on all 26 repositories
  • 90 open Dependabot PRs closed org-wide

Important

Disabling alerts also stops CVE notifications for dependencies. Nothing else
in these repos currently watches for vulnerable dependencies, so that
coverage is gone until something replaces it.

Code review agent added

Two layers, deliberately split so routine PRs stay cheap:

Runs Scope
Copilot Automatically on every PR to the default branch Fast first pass. Enforced by the Code Quality Copilot review for default branch ruleset, now active.
Claude On demand Deeper pass. Triggered by @claude in a comment, or by adding the deep-review label to a PR.

.github/workflows/claude-code-review.yml uses anthropics/claude-code-action@v1.
Its review prompt points Claude at this repo's own CLAUDE.md, QUALITY.md,
TESTING.md, SECURITY.md and VERIFY.md rather than generic style rules, and
prioritises correctness → security → tests → maintainability.

Warning

Two prerequisites are not satisfied yet, and both need an org admin:

  1. ANTHROPIC_API_KEY org secret does not exist. Until it is added, both
    Claude jobs fail fast with a clear error rather than running without
    credentials.
  2. Copilot seats: 0 assigned. The org has Copilot Business available but
    seat_breakdown.total is 0, so the ruleset is active but nothing reviews
    until seats are assigned. That is a billing action, deliberately left alone.

Verification

Builds and test suites were run on this branch; results are in the PR
conversation where the branch carries code changes.

Dependabot is disabled org-wide: config removed here, and alerts plus
automated security fixes turned off via the API. 90 open Dependabot PRs
were closed. Note this also stops CVE alerts for dependencies.

Adds .github/workflows/claude-code-review.yml. It complements the
automatic Copilot review now enforced on the default branch: Copilot
does the first pass on every PR, Claude runs on demand via @claude or
the deep-review label. Needs an ANTHROPIC_API_KEY secret.

Also includes audit fixes:

Ed25519 verification rejected every valid signature (SHA-256 challenge
instead of SHA-512, plus broken curve arithmetic). Replaced the
verifier, added SHA-512, replaced tests that could not fail, fixed a
mismatched extern prototype, and built two source files that were never
compiled. CI configured -DBUILD_TESTS=ON but the option is
EBLDR_BUILD_TESTS, so it ran zero tests and passed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant