[build-tools] add worker-side ssh session helper#4030
Draft
gwdp wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 16, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gwdp/eng-24547-eas-build-job-ssh #4030 +/- ##
===================================================================
Coverage ? 61.15%
===================================================================
Files ? 965
Lines ? 42947
Branches ? 9060
===================================================================
Hits ? 26262
Misses ? 16591
Partials ? 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gwdp
force-pushed
the
gwdp/eng-24547-eas-build-job-ssh
branch
from
July 16, 2026 19:05
72fb902 to
25fb902
Compare
gwdp
force-pushed
the
gwdp/eng-24547-build-tools-ssh-session
branch
3 times, most recently
from
July 16, 2026 22:20
a7b6154 to
c9e54b9
Compare
gwdp
force-pushed
the
gwdp/eng-24547-eas-build-job-ssh
branch
from
July 16, 2026 22:20
25fb902 to
19047e6
Compare
gwdp
force-pushed
the
gwdp/eng-24547-build-tools-ssh-session
branch
from
July 17, 2026 02:37
c9e54b9 to
12f0a14
Compare
gwdp
force-pushed
the
gwdp/eng-24547-eas-build-job-ssh
branch
from
July 21, 2026 02:08
19047e6 to
1277e59
Compare
gwdp
force-pushed
the
gwdp/eng-24547-build-tools-ssh-session
branch
from
July 21, 2026 02:08
12f0a14 to
12feb7a
Compare
|
✅ Thank you for adding the changelog entry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
The worker needs a piece that starts an SSH session on the build VM and keeps the worker alive while someone is connected.
How
New helper resolves the upterm client vendored in the worker package, dials the relay, reports the connection details back so the CLI can attach, and holds on an idle timer. Redialing is bounded by a shared budget so a flapping relay can't retry forever. Connection secrets are scrubbed from logs.
Test Plan
Unit tests cover the connection parsing, secret redaction, process-liveness detection, the bounded redial budget, and the idle hold. CI passes.