Skip to content

[eas-cli] add --ssh to workflow:run#4033

Draft
gwdp wants to merge 1 commit into
gwdp/eng-24550-workflow-ssh-commandfrom
gwdp/eng-24550-workflow-run-ssh-flag
Draft

[eas-cli] add --ssh to workflow:run#4033
gwdp wants to merge 1 commit into
gwdp/eng-24550-workflow-ssh-commandfrom
gwdp/eng-24550-workflow-run-ssh-flag

Conversation

@gwdp

@gwdp gwdp commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Why

Lets you enable SSH when starting a run, so you can connect to it afterwards with eas workflow:ssh:

eas workflow:run --ssh

How

Adds --ssh and --ssh-idle-timeout to workflow:run. The flags feed a single SSH input on both run-creation mutations, which marks the run's VM jobs as SSH-enabled. --ssh-idle-timeout without --ssh is rejected; the server owns the timeout default and clamp.

Test Plan

Unit tests cover input resolution, including the timeout-without---ssh rejection. CI passes.

@linear-code

linear-code Bot commented Jul 16, 2026

Copy link
Copy Markdown

ENG-24550

gwdp commented Jul 16, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (gwdp/eng-24550-workflow-ssh-command@43999d9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/workflow/run.ts 62.50% 3 Missing ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##             gwdp/eng-24550-workflow-ssh-command    #4033   +/-   ##
======================================================================
  Coverage                                       ?   61.26%           
======================================================================
  Files                                          ?      967           
  Lines                                          ?    43070           
  Branches                                       ?     9085           
======================================================================
  Hits                                           ?    26382           
  Misses                                         ?    16594           
  Partials                                       ?       94           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 1f547bf to 778203e Compare July 16, 2026 19:05
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch 2 times, most recently from f3f63db to b3131bb Compare July 16, 2026 22:18
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 778203e to 5d9f23c Compare July 16, 2026 22:18
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from b3131bb to cc50b51 Compare July 16, 2026 22:20
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 5d9f23c to 12588a3 Compare July 16, 2026 22:20
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from cc50b51 to 4d9be2c Compare July 17, 2026 02:37
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 12588a3 to 0a9a189 Compare July 17, 2026 02:37
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-ssh-command branch from 4d9be2c to 43999d9 Compare July 21, 2026 02:08
@gwdp
gwdp force-pushed the gwdp/eng-24550-workflow-run-ssh-flag branch from 0a9a189 to dc55796 Compare July 21, 2026 02:08
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant