[keelerm84]

Summary

TestDataFlagBuilder.valueForAll in the server SDK replaced the flag's variations with the single value and called variationForAll(0), which leaves the off variation unchanged. A new test flag is a boolean flag with off variation 1, so the built flag had variations: [value] and offVariation: 1. That index is out of range, so the flag failed to evaluate (malformed flag) when targeting was off. The method is documented to return the value whether targeting is on or off.

valueForAll now also sets the off variation to 0. variationForAll is unchanged; it still leaves the off variation alone, as documented.

The new tests check that the built off variation is 0 with targeting on and off, and that the client evaluates a valueForAll flag with targeting off to the value with an OFF reason.

This matches the Ruby fix in launchdarkly/ruby-server-sdk#489.

_{Opened from termag}

---

Note

Overview
Fixes TestData valueForAll so flags evaluate correctly when targeting is off. Previously it collapsed the flag to a single variation and set fallthrough to index 0 but left the default off variation at index 1, which is out of range and produced malformed flag errors instead of the configured value.

valueForAll now also sets off variation to 0, matching its documented behavior (same value on or off). variationForAll is unchanged and still does not alter the off variation.

New tests cover the built flag shape and LDClient evaluation with targeting off (OFF reason and the expected value).

^{Reviewed by Cursor Bugbot for commit 6f2c0bb. Bugbot is set up for automated code reviews on this repo. Configure here.}

[github-actions]

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Compressed size: 34510 bytes
Compressed size limit: 35000
Uncompressed size: 123185 bytes

[github-actions]

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 32490 bytes
Compressed size limit: 32500
Uncompressed size: 153198 bytes

[github-actions]

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Compressed size: 26066 bytes
Compressed size limit: 44000
Uncompressed size: 168326 bytes