fix: Make TestData valueForAll return its value when targeting is off

packages/shared/sdk-server/__tests__/LDClient.evaluation.test.ts

@@ -200,6 +200,14 @@ describe('given an LDClient with test data', () => {
     expect(stringRes).toBe('potato');
   });
 
+  it('evaluates a value for all flag to its value when targeting is off', async () => {
+    await td.update(td.flag('flagkey').valueForAll('potato').on(false));
+    const detail = await client.variationDetail('flagkey', defaultUser, 'default');
+    expect(detail.value).toEqual('potato');
+    expect(detail.variationIndex).toEqual(0);
+    expect(detail.reason).toEqual({ kind: 'OFF' });
+  });
+
   it('evaluates an existing boolean flag', async () => {
     td.update(td.flag('flagkey').booleanFlag().on(true));
     expect(await client.boolVariation('flagkey', defaultUser, false)).toEqual(true);

packages/shared/sdk-server/__tests__/integrations/test_data/TestData.test.ts

@@ -251,6 +251,14 @@ describe('given a TestData instance', () => {
     const built = flag.build(1);
     expect(built.variations).toEqual(['potato']);
     expect(built.fallthrough.variation).toEqual(0);
+    expect(built.offVariation).toEqual(0);
+  });
+
+  it('sets the off variation to the value for all when targeting is off', () => {
+    const built = td.flag('test-flag').valueForAll('potato').on(false).build(1);
+    expect(built.on).toBe(false);
+    expect(built.variations).toEqual(['potato']);
+    expect(built.offVariation).toEqual(0);
   });
 
   it('can handle boolean values for *Variation setters', () => {

packages/shared/sdk-server/src/integrations/test_data/TestDataFlagBuilder.ts

@@ -196,7 +196,7 @@ export default class TestDataFlagBuilder {
    * @return the flag builder
    */
   valueForAll(value: any): TestDataFlagBuilder {
-    return this.variations(value).variationForAll(0);
+    return this.variations(value).variationForAll(0).offVariation(0);
   }
 
   /**