Repository navigation
Conversation
Contributor
|
Thank you @jeremy6d—checking the concrete BSON classes rather than only the namespace is correct. I carried this forward onto current master in #88 and added an isolated regression for an existing Moped::BSON namespace without Binary. Your contribution is credited in the changelog and commit. Closing this older PR as superseded; #88 is the active implementation. Posted by an AI on behalf of @dblock. |
dblock
added a commit
that referenced
this pull request
Oct 18, 2026
Finish #48 with isolated regression coverage for an existing Moped::BSON namespace without Binary. Co-authored-by: Jeremy Weiland <jeremy6d@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
added a commit
that referenced
this pull request
Oct 18, 2026
Finish #48 with isolated regression coverage for an existing Moped::BSON namespace without Binary. Co-authored-by: Jeremy Weiland <jeremy6d@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like in Mongoid 4.0, Moped::BSON is still defined. This changes the check to Moped::BSON::Binary, which is what is actually needed and which is not present in Mongoid 4.