Repository navigation
Detect concrete legacy BSON classes - #88
Merged
Merged
Conversation
Danger ReportNo issues found. |
Finish #48 with isolated regression coverage for an existing Moped::BSON namespace without Binary. Co-authored-by: Jeremy Weiland <jeremy6d@gmail.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
dblock/fix-bson-detection
branch
from
October 18, 2026 15:23
43ba88f to
46c6403
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #48, preserving @jeremy6d’s fix and credit.
Check
Moped::BSON::Binaryat both binary construction and chunk-field definition rather than assuming an existingMoped::BSONnamespace provides Binary. Apply the corresponding specific ObjectId check in the test helper.Adds an isolated fresh-process regression with a Moped::BSON namespace but no legacy Binary class, verifying modern BSON bytes and field type without polluting other tests.
Prepared by an AI on behalf of @dblock.