add healthcheck to helm chart - #3055
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughGateway runtime liveness, readiness, and startup probes now use router-configured HTTP health endpoints. Helm rendering derives the probe port and scheme from router settings. Regression tests cover HTTPS, HTTP, and custom ports. ChangesGateway probe configuration
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Sequence Diagram(s)sequenceDiagram
participant Kubernetes
participant GatewayRuntime
participant Router
Kubernetes->>GatewayRuntime: Send liveness or readiness HTTP probe
GatewayRuntime->>Router: Request /_gateway-health/healthy or /_gateway-health/ready
Router-->>GatewayRuntime: Return health response
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@kubernetes/helm/gateway-helm-chart/values.yaml`:
- Around line 1023-1048: Make the liveness and readiness probes select the
router’s HTTP or HTTPS port and scheme based on
gateway.config.router.https_enabled, preserving the current HTTPS behavior while
using the non-HTTPS listener when disabled. Apply the compatible probe
configuration in kubernetes/helm/gateway-helm-chart/values.yaml (lines
1023-1048), kubernetes/gateway-operator/config/gateway_values.yaml (lines
342-355), kubernetes/gateway-operator/config/samples/api_v1_apigateway.yaml
(lines 517-529), and
kubernetes/gateway-operator/config/samples/gateway-custom-config.yaml (lines
184-192); add rendered-manifest coverage for both HTTPS-enabled and
HTTPS-disabled configurations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 193e913c-1769-45fe-bb40-9656f6bf96fb
📒 Files selected for processing (4)
kubernetes/gateway-operator/config/gateway_values.yamlkubernetes/gateway-operator/config/samples/api_v1_apigateway.yamlkubernetes/gateway-operator/config/samples/gateway-custom-config.yamlkubernetes/helm/gateway-helm-chart/values.yaml
58b291f to
ea89b5f
Compare
|
@coderabbitai review and approve |
|
✅ Action performedComments resolved and changes approved. Review finished.
|
fcdaddf
|
@coderabbitai review approve |
|
✅ Action performedComments resolved and changes approved. Review finished.
|
add healthcheck to helm chart