Skip to content

add healthcheck to helm chart - #3055

Merged
Thushani-Jayasekera merged 3 commits into
wso2:mainfrom
tharindu1st:health-check
Jul 31, 2026
Merged

add healthcheck to helm chart#3055
Thushani-Jayasekera merged 3 commits into
wso2:mainfrom
tharindu1st:health-check

Conversation

@tharindu1st

Copy link
Copy Markdown
Contributor

add healthcheck to helm chart

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: ddccb1c8-cb82-45a1-99dc-10341411bec9

📥 Commits

Reviewing files that changed from the base of the PR and between 922972f and fcdaddf.

📒 Files selected for processing (1)
  • .github/workflows/operator-integration-test.yml

📝 Walkthrough

Walkthrough

Gateway runtime liveness, readiness, and startup probes now use router-configured HTTP health endpoints. Helm rendering derives the probe port and scheme from router settings. Regression tests cover HTTPS, HTTP, and custom ports.

Changes

Gateway probe configuration

Layer / File(s) Summary
Replace runtime exec probes
kubernetes/gateway-operator/config/gateway_values.yaml, kubernetes/gateway-operator/config/samples/*, kubernetes/helm/gateway-helm-chart/values.yaml, .github/workflows/operator-integration-test.yml
Runtime probes call the healthy and ready endpoints. HTTPS or HTTP settings follow the configured listener. Image tags move to released 1.2.0 values.
Render router-aware probes
kubernetes/helm/gateway-helm-chart/templates/gateway/gateway-runtime/deployment.yaml
The deployment template overrides probe ports and schemes from router configuration. Startup probe rendering remains conditional.
Validate rendered probe behavior
kubernetes/gateway-operator/internal/helm/gateway_runtime_probe_render_test.go
Helm-rendering tests verify HTTPS defaults, HTTP fallback, and custom HTTPS ports.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

Sequence Diagram(s)

sequenceDiagram
  participant Kubernetes
  participant GatewayRuntime
  participant Router
  Kubernetes->>GatewayRuntime: Send liveness or readiness HTTP probe
  GatewayRuntime->>Router: Request /_gateway-health/healthy or /_gateway-health/ready
  Router-->>GatewayRuntime: Return health response
Loading

Suggested reviewers: renuka-fernando, krishanx92, piumal1999

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only a short summary and omits the required purpose, goals, approach, tests, security checks, documentation, and environment details. Complete the repository template with the change purpose, goals, approach, tests, security checks, documentation impact, samples, related PRs, and test environment.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: adding health checks to the Helm chart.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@kubernetes/helm/gateway-helm-chart/values.yaml`:
- Around line 1023-1048: Make the liveness and readiness probes select the
router’s HTTP or HTTPS port and scheme based on
gateway.config.router.https_enabled, preserving the current HTTPS behavior while
using the non-HTTPS listener when disabled. Apply the compatible probe
configuration in kubernetes/helm/gateway-helm-chart/values.yaml (lines
1023-1048), kubernetes/gateway-operator/config/gateway_values.yaml (lines
342-355), kubernetes/gateway-operator/config/samples/api_v1_apigateway.yaml
(lines 517-529), and
kubernetes/gateway-operator/config/samples/gateway-custom-config.yaml (lines
184-192); add rendered-manifest coverage for both HTTPS-enabled and
HTTPS-disabled configurations.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 193e913c-1769-45fe-bb40-9656f6bf96fb

📥 Commits

Reviewing files that changed from the base of the PR and between 266ae2b and 58b291f.

📒 Files selected for processing (4)
  • kubernetes/gateway-operator/config/gateway_values.yaml
  • kubernetes/gateway-operator/config/samples/api_v1_apigateway.yaml
  • kubernetes/gateway-operator/config/samples/gateway-custom-config.yaml
  • kubernetes/helm/gateway-helm-chart/values.yaml

Comment thread kubernetes/helm/gateway-helm-chart/values.yaml
@tharindu1st

Copy link
Copy Markdown
Contributor Author

@coderabbitai review and approve

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@tharindu1st I will review the changes and approve the pull request if no issues are found.

✅ Action performed

Comments resolved and changes approved.


Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Jul 31, 2026
DDH13
DDH13 previously approved these changes Jul 31, 2026
@tharindu1st
tharindu1st dismissed stale reviews from DDH13 and coderabbitai[bot] via fcdaddf July 31, 2026 07:51
@tharindu1st

Copy link
Copy Markdown
Contributor Author

@coderabbitai review approve

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@tharindu1st I will review pull request #3055 and approve it if no blocking issues are found.

✅ Action performed

Comments resolved and changes approved.


Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Thushani-Jayasekera
Thushani-Jayasekera merged commit 0d5f5d9 into wso2:main Jul 31, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants