fix: restore Chinese Ask streaming copy - #2949
Merged
esokullu merged 2 commits intoAug 29, 2026
Merged
Conversation
xianhongtao
commented
Aug 29, 2026
xianhongtao
commented
Contributor
|
@xianhongtao is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
PR webbrain-one#2949 fixed 'st.display.openai_ask_streaming.label'/'.desc' in zh.js (chrome + firefox), which had shipped as literal runs of '?' instead of translated Chinese text. The existing locale-parity test only checks key presence and {placeholder} token parity, so a garbled '?'-only value (zero placeholders, matching its English source) passes it trivially and would not have caught this bug, or would catch a recurrence. Add a small, targeted regression test scoped to the exact key/locale this PR restores. Intentionally not extended to all locales/keys: ar, bn, fa, he, hi, ja, ko, ru, th, uk currently have the identical unfixed corruption for this same key and are out of scope for this PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Collaborator
|
thank you @xianhongtao I don't know when this happened. Very valuable contribution. Many thanks! Merging now. |
esokullu
added a commit
that referenced
this pull request
Aug 29, 2026
'st.display.openai_ask_streaming.label'/'.desc' have shipped as literal runs of '?' (e.g. "? Ask ????????") since commit e9643a6 ("Add 76 LLM providers and Ask streaming") in ar, bn, fa, he, hi, ja, ko, ru, th, uk — in both the chrome and firefox locale directories (20 files, 40 lines). PR #2949 restored only zh; this restores the remaining 10 locales with native-quality copy via an idempotent replace-in-place pass added to scripts/i18n-perm-translations.mjs. Also generalize the PR #2949 mojibake regression guard from zh-only to every locale in test/run.js, so a recurrence of '?'-run corruption fails the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.